Workflow for publishing to oidc-sweden github packages#11
Open
danneleaf wants to merge 5 commits intooidc-sweden:mainfrom
Open
Workflow for publishing to oidc-sweden github packages#11danneleaf wants to merge 5 commits intooidc-sweden:mainfrom
danneleaf wants to merge 5 commits intooidc-sweden:mainfrom
Conversation
Signed-off-by: Johannes Dannelov <johannes.dannelov@digg.se>
…x deprecated mvn flag syntax Signed-off-by: Johannes Dannelov <johannes.dannelov@digg.se>
Signed-off-by: Johannes Dannelov <johannes.dannelov@digg.se>
…nt-path chore: add deployment to oidc-sweden packages
martin-lindstrom
approved these changes
Dec 19, 2024
|
@danneleaf Kikade snabbt, saknar lite metadata i pom:en om copyright. Kan reviewa denna senare! |
|
Starting to code reviewing this
So according to this knowledge, if the last part regarding poc is also correct, I think we should not waste any more time than necessary on it, and I suggest, instead of adding more workflows for also building to GH registry ...( and i was planning on adding even more security checks and other fun stuff) etc we instead:
@danneleaf @martin-lindstrom @Razumain Above sounds good? Could @martin-lindstrom or @Razumain publish 2.0.2 for us it would be super, gracias. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add GitHub Packages publishing workflow while maintaining existing deployment configuration. This allows us to:
Use GitHub Packages for tagged versions
Keep the existing sonatype configuration
The existing distribution management settings for OSSRH remain unchanged. The GitHub Packages workflow is configured to run only on specific tags, ensuring it doesn't interfere with the main release process.